mods. to DeviceTab classes to correctly handle background dev. manage…

…ment tabs
eclipse · Apr 17, 2023 · 0fb2895 · 0fb2895
1 parent 4723cc1
commit 0fb2895
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 22 deletions.
diff --git a/...ava/org/eclipse/kapua/app/console/module/device/client/device/assets/DeviceTabAssets.java b/...ava/org/eclipse/kapua/app/console/module/device/client/device/assets/DeviceTabAssets.java
@@ -55,8 +55,11 @@ public void setEntity(GwtDevice gwtDevice) {
             setEnabled(false);
             getHeader().setVisible(false);
         }
-        assetsValues.setDevice(gwtDevice);
-        doRefresh();
+
+        if (selectedEntity != null) {
+            assetsValues.setDevice(gwtDevice);
+        }
+
     }
 
     @Override
@@ -66,7 +69,7 @@ public void doRefresh() {
             return;
         }
 
-        if (tabsPanel.getSelectedItem() == this) {
+        if (tabsPanel.getSelectedItem() == tabValues) {
             assetsValues.refresh();
         }
     }

diff --git a/...a/org/eclipse/kapua/app/console/module/device/client/device/bundles/DeviceTabBundles.java b/...a/org/eclipse/kapua/app/console/module/device/client/device/bundles/DeviceTabBundles.java
@@ -72,7 +72,6 @@ public class DeviceTabBundles extends KapuaTabItem<GwtDevice> {
 
     private final GwtDeviceManagementServiceAsync gwtDeviceManagementService = GWT.create(GwtDeviceManagementService.class);
     private final GwtSecurityTokenServiceAsync gwtXSRFService = GWT.create(GwtSecurityTokenService.class);
-
     private DeviceView devicesView;
 
     private boolean initialized;
@@ -107,7 +106,6 @@ public void setEntity(GwtDevice gwtDevice) {
             setEnabled(false);
             getHeader().setVisible(false);
         }
-        doRefresh();
     }
 
     @Override
@@ -406,7 +404,7 @@ public DataLoadListener() {
         @Override
         public void loaderBeforeLoad(LoadEvent le) {
             disableButtons();
-            grid.mask(MSGS.loading());
+            //grid.mask(MSGS.loading());
         }
 
         @Override
@@ -422,7 +420,6 @@ public void loaderLoad(LoadEvent le) {
 
         @Override
         public void loaderLoadException(LoadEvent le) {
-
             if (le.exception != null && le.exception instanceof GwtKapuaException) {
                 FailureHandler.handle(le.exception);
             } else {

diff --git a/...a/org/eclipse/kapua/app/console/module/device/client/device/command/DeviceTabCommand.java b/...a/org/eclipse/kapua/app/console/module/device/client/device/command/DeviceTabCommand.java
@@ -109,7 +109,6 @@ public void setEntity(GwtDevice gwtDevice) {
             setEnabled(false);
             getHeader().setVisible(false);
         }
-        doRefresh();
     }
 
     @Override

diff --git a/...e/kapua/app/console/module/device/client/device/configuration/DeviceConfigComponents.java b/...e/kapua/app/console/module/device/client/device/configuration/DeviceConfigComponents.java
@@ -155,7 +155,6 @@ public DeviceConfigComponents(GwtSession currentSession, DeviceTabConfiguration
     public void setDevice(GwtDevice selectedDevice) {
         dirty = true;
         this.selectedDevice = selectedDevice;
-        refresh();
     }
 
     @Override

diff --git a/...e/kapua/app/console/module/device/client/device/configuration/DeviceTabConfiguration.java b/...e/kapua/app/console/module/device/client/device/configuration/DeviceTabConfiguration.java
@@ -59,25 +59,32 @@ public void setEntity(GwtDevice gwtDevice) {
             setEnabled(false);
             getHeader().setVisible(false);
         }
-        doRefresh();
+
+        if (selectedEntity != null) {
+            // Configurations
+            configComponents.setDevice(selectedEntity);
+
+            // Snapshot
+            configSnapshots.setDevice(selectedEntity);
+        }
+
     }
 
     @Override
     public void doRefresh() {
-
         if (tabsPanel == null) {
             return;
         }
 
+        if (selectedEntity != null) {
+            tabSnapshots.setEnabled(selectedEntity.isOnline());
+        }
         if (tabsPanel.getSelectedItem() == tabComponents) {
             configComponents.refresh();
         } else if (tabsPanel.getSelectedItem() == tabSnapshots) {
             configSnapshots.refresh();
         }
-        if (selectedEntity != null) {
-            configComponents.setDevice(selectedEntity);
-            configSnapshots.setDevice(selectedEntity);
-        }
+
     }
 
     @Override

diff --git a/...g/eclipse/kapua/app/console/module/device/client/device/inventory/DeviceTabInventory.java b/...g/eclipse/kapua/app/console/module/device/client/device/inventory/DeviceTabInventory.java
@@ -78,11 +78,6 @@ public void setEntity(GwtDevice gwtDevice) {
             tabsPanel.setSelection(inventoryDeploymentPackageTab);
         }
 
-        if (toolBar != null) {
-            toolBar.setEnabled(getSelectedDevice() != null);
-        }
-
-        doRefresh();
     }
 
     @Override

diff --git a/...org/eclipse/kapua/app/console/module/device/client/device/keystore/DeviceTabKeystore.java b/...org/eclipse/kapua/app/console/module/device/client/device/keystore/DeviceTabKeystore.java
@@ -101,7 +101,6 @@ public void setEntity(GwtDevice gwtDevice) {
             getHeader().setVisible(false);
         }
 
-        refresh();
     }
 
     @Override

diff --git a/...org/eclipse/kapua/app/console/module/device/client/device/packages/DeviceTabPackages.java b/...org/eclipse/kapua/app/console/module/device/client/device/packages/DeviceTabPackages.java
@@ -105,7 +105,6 @@ public void setEntity(GwtDevice gwtDevice) {
             historyPackageTab.setEntity(gwtDevice);
         }
 
-        doRefresh();
     }
 
     @Override