Integrated feedback on implementation of 'setStepPropertiesOverrides'

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
eclipse · Jul 3, 2023 · 25537a2 · 25537a2
1 parent 8729304
commit 25537a2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ngine/client/src/main/java/org/eclipse/kapua/job/engine/client/JobStartOptionsClient.java b/...ngine/client/src/main/java/org/eclipse/kapua/job/engine/client/JobStartOptionsClient.java
@@ -76,7 +76,7 @@ public void addStepPropertyOverride(JobStepProperty jobStepPropertyOverride) {
 
     @Override
     public void setStepPropertiesOverrides(List<JobStepProperty> stepPropertiesOverrides) {
-        this.stepPropertiesOverrides = stepPropertiesOverrides;
+        this.stepPropertiesOverrides = new ArrayList<>(stepPropertiesOverrides);
     }
 
     @Override

diff --git a/job-engine/jbatch/src/main/java/org/eclipse/kapua/job/engine/jbatch/JobStartOptionsImpl.java b/job-engine/jbatch/src/main/java/org/eclipse/kapua/job/engine/jbatch/JobStartOptionsImpl.java
@@ -97,7 +97,7 @@ public void addStepPropertyOverride(JobStepProperty stepPropertyOverride) {
 
     @Override
     public void setStepPropertiesOverrides(List<JobStepProperty> stepPropertiesOverrides) {
-        this.stepPropertiesOverrides = stepPropertiesOverrides;
+        this.stepPropertiesOverrides = new ArrayList<>(stepPropertiesOverrides);
     }
 
     @Override