New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Device Birth Extended Properties #3273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3273 +/- ##
=============================================
+ Coverage 25.47% 25.80% +0.33%
- Complexity 655 658 +3
=============================================
Files 1467 1470 +3
Lines 29943 30025 +82
Branches 2504 2507 +3
=============================================
+ Hits 7629 7749 +120
+ Misses 21716 21670 -46
- Partials 598 606 +8
|
lorthirk
approved these changes
Mar 16, 2021
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-extensibleBirth
branch
from
March 17, 2021 10:01
6e659f7
to
2667032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for
extendedProperties
in Birth message sent from the device.Related Issue
None
Description of the solution adopted
This PR adds mapping and resources to store the extendedProperties metric sent by Kura.
Those properties will be sent as an additional metric in the BIRTH message in a well defined JSON format.
Those properties are read and stored as an additional field of the Device entity to allow query easily those values.
Values from the device are not parsed (other than the value itself) nor there is logic on them because they can change from device to device.
Screenshots
Some screenshot of the new values in console.
Any side note on the changes made
Completed a bit the Javadocs of Device-related entities.