Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom ES Rest Client error handler #3564

Merged

Conversation

riccardomodanese
Copy link
Contributor

Brief description of the PR.
This pr adds a proper error handler for the Rest client as suggested by this issue:
elastic/elasticsearch#49124

Related Issue
fix #3563

Description of the solution adopted
The custom error handler should prevent the I/O reactor to be stopped by an error coming from the underlying layer.

Screenshots
none

Any side note on the changes made
none

@riccardomodanese riccardomodanese added the Bug This is a bug or an unexpected behaviour. Fix it! label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3564 (7808948) into develop (a0a5ee1) will decrease coverage by 3.09%.
The diff coverage is 47.22%.

❗ Current head 7808948 differs from pull request most recent head bf06304. Consider uploading reports for the commit bf06304 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3564      +/-   ##
=============================================
- Coverage      50.12%   47.02%   -3.10%     
  Complexity       259      259              
=============================================
  Files           1662     1662              
  Lines          31900    31929      +29     
  Branches        2642     2643       +1     
=============================================
- Hits           15989    15016     -973     
- Misses         14973    15995    +1022     
+ Partials         938      918      -20     
Impacted Files Coverage Δ
...sticsearch/client/AbstractElasticsearchClient.java 0.00% <ø> (ø)
...ticsearch/client/rest/RestElasticsearchClient.java 60.77% <0.00%> (-1.10%) ⬇️
...h/client/rest/RestElasticsearchClientProvider.java 51.26% <54.83%> (+0.98%) ⬆️
...lipse/kapua/service/tag/internal/TagQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
.../kapua/service/tag/internal/TagListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...rvice/endpoint/internal/EndpointInfoQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
.../job/targets/internal/JobTargetListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
.../endpoint/internal/EndpointInfoListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...pua/service/endpoint/internal/EndpointInfoDAO.java 0.00% <0.00%> (-93.34%) ⬇️
...org/eclipse/kapua/service/tag/internal/TagDAO.java 0.00% <0.00%> (-90.91%) ⬇️
... and 73 more

riccardomodanese and others added 3 commits June 27, 2022 09:30
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
…ct task

Signed-off-by: Elbert Evangelista <elbert.evangelista@eurotech.com>
Signed-off-by: Elbert Evangelista <elbert.evangelista@eurotech.com>
@riccardomodanese riccardomodanese merged commit aef10f8 into eclipse:develop Jun 27, 2022
@Coduz Coduz added this to In Progress in 2.0.0 via automation Jun 27, 2022
@Coduz Coduz added this to In Progress in 1.6.0 via automation Jun 27, 2022
@Coduz Coduz added this to Backport in 1.5.6 via automation Jun 27, 2022
@Coduz Coduz moved this from In Progress to Done in 1.6.0 Jun 27, 2022
@Coduz Coduz moved this from In Progress to Done in 2.0.0 Jun 27, 2022
@Coduz Coduz moved this from Backport to Backport Ready in 1.5.6 Jun 27, 2022
@Coduz Coduz moved this from Backport Ready to Done in 1.5.6 Jun 27, 2022
@Coduz Coduz removed this from Done in 1.6.0 Jun 27, 2022
@Coduz Coduz added this to Backport in 1.6.1 via automation Jun 27, 2022
@Coduz Coduz moved this from Backport to Backport Ready in 1.6.1 Jun 27, 2022
@Coduz Coduz moved this from Backport Ready to Done in 1.6.1 Jun 27, 2022
@riccardomodanese riccardomodanese deleted the fix-restESClientErrorHandler branch October 13, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
1.5.6
Done
1.6.1
Done
2.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

Datatstore ingestion stop working after a while
2 participants