-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom ES Rest Client error handler #3564
Merged
riccardomodanese
merged 3 commits into
eclipse:develop
from
riccardomodanese:fix-restESClientErrorHandler
Jun 27, 2022
Merged
Implement custom ES Rest Client error handler #3564
riccardomodanese
merged 3 commits into
eclipse:develop
from
riccardomodanese:fix-restESClientErrorHandler
Jun 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3564 +/- ##
=============================================
- Coverage 50.12% 47.02% -3.10%
Complexity 259 259
=============================================
Files 1662 1662
Lines 31900 31929 +29
Branches 2642 2643 +1
=============================================
- Hits 15989 15016 -973
- Misses 14973 15995 +1022
+ Partials 938 918 -20
|
elbert3
approved these changes
Jun 24, 2022
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
…ct task Signed-off-by: Elbert Evangelista <elbert.evangelista@eurotech.com>
Signed-off-by: Elbert Evangelista <elbert.evangelista@eurotech.com>
dedfbf5
to
bf06304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR.
This pr adds a proper error handler for the Rest client as suggested by this issue:
elastic/elasticsearch#49124
Related Issue
fix #3563
Description of the solution adopted
The custom error handler should prevent the I/O reactor to be stopped by an error coming from the underlying layer.
Screenshots
none
Any side note on the changes made
none