Drop mandatory gzip compression #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR drops the gzip compression servlet filter. 1) The servlet is deprected and missing in most recent Jetty versions 2) When using HTTPS (and Kapua should be used over HTTPS) then gzip compression might trigger the BREACH exploit 3) If compression is still wanted, it should be enabled in the front-facing HTTP engine 4) It fixes an issue with the out date GWT plugin [1] https://en.wikipedia.org/wiki/BREACH_%28security_exploit%29
ctron
added
Console GWT
|
Fixes #374 |
lorthirk
approved these changes
Mar 14, 2017
|
@kartben as per your suggestion I opened an issue on Bugzilla to further investigate this item since it has security implications, but it seems the issue is still publicly available with no restrictions. Isn't http://bugs.eclipse.org the correct URL for this? |
|
The followup issue is tracked here. Any input is really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the gzip compression servlet filter.
compression might trigger the BREACH exploit
front-facing HTTP engine
[1] https://en.wikipedia.org/wiki/BREACH_%28security_exploit%29