Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dash check runs in the "wrong place" in CI for Rust builds #677

Closed
SebastianSchildt opened this issue Sep 29, 2023 · 0 comments · Fixed by #680
Closed

Dash check runs in the "wrong place" in CI for Rust builds #677

SebastianSchildt opened this issue Sep 29, 2023 · 0 comments · Fixed by #680
Assignees
@erikbosch
Labels
CI CI related issues

Comments

@SebastianSchildt
Copy link
Contributor

For databroker(-cli) we

  • create an input file for Dash and a BOM (createbom)
  • Run the dash tool agains the input file and archive outcomes

This currently is done in the "Lint" step, which seems wrong (was likely done to "recylce" the builder").

See https://github.com/eclipse/kuksa.val/actions/runs/6328141013/job/17246390201

Way forward seems

  • do not do the Createbom in the "lint" step but have something in buold or seperate
  • The DASH tool check (e.g. processing a Dash file and archiving the outputs) should be spun out in a separate action probably in the shared actions repository, as this is the same no matter we do it for pyton, rust, Kotlin etc....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikbosch erikbosch

Labels
CI CI related issues
Projects
None yet
Milestone
No milestone
2 participants
@SebastianSchildt @erikbosch