Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default behavior to only track relevant services #1174

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Mar 9, 2017

Also change private fields to new Kura style.

Signed-off-by: Jens Reimann jreimann@redhat.com

@ctron ctron added this to the KURA-3.0.0-M2 milestone Mar 9, 2017
@ctron ctron requested review from cdealti and MMaiero March 9, 2017 13:48
@ctron ctron force-pushed the feature/default_track_only_1 branch 2 times, most recently from 1412815 to 00449bd Compare March 9, 2017 15:03
@cdealti
Copy link
Contributor

cdealti commented Mar 9, 2017

Maybe we could use this PR to also remove some wrong registered services.
Examples need to only provide ConfigurableComponent. Registering an implementation class does not makes sense.
See c88cce6

Also change private fields to new Kura style.

Signed-off-by: Jens Reimann <jreimann@redhat.com>
@ctron ctron force-pushed the feature/default_track_only_1 branch from 00449bd to 80f0de0 Compare March 10, 2017 08:21
@ctron
Copy link
Contributor Author

ctron commented Mar 10, 2017

Sure, I can amend this PR.

@ctron
Copy link
Contributor Author

ctron commented Mar 10, 2017

On a second thought, maybe we keep this as is not to break accidentally anything. Because this change cannot be reversed by changing a system property.

@ctron
Copy link
Contributor Author

ctron commented Mar 14, 2017

We will create a new PR for removing the double registration.

@MMaiero
Copy link
Contributor

MMaiero commented Mar 16, 2017

Merging. Let's see what happens 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants