Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Oomph setup and clean up build issues #320

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Jul 13, 2016

This changes adds an Oomph based setup which follows the
"Getting Started" tutorial. It will allow the user to choose between
a minimal set as described in the tutorial or a full Kura developer
setup.

For this it was necessary to also fix a few project issues in order to
create a, mostly, error free workspace.

The steps to be taken for the end user are:

  • Install Java 8
  • Download and run the Eclipse installer
    • Select Eclipse IDE edition
    • Select "Eclipse Kura"
    • Enter location for installation
    • Wait a few minutes

In addition this change fixes a few project settings issues:

  • org.eclipse.soda.dk.comm package path (actually is
    src/main/java/org/eclipse/soda/dk instead of
    src/main/java/org/eclipse/soda/dk/comm)
  • Don't ignore Tycho and WTP maven plugins but install m2eclipse
    adapters instead

Signed-off-by: Jens Reimann jreimann@redhat.com

@ctron ctron changed the title Fix the directory structure of "org.eclipse.soda.dk.comm" to match the package name Fix the package structure of "org.eclipse.soda.dk.comm" and add Ommph setup Jul 13, 2016
@ctron
Copy link
Contributor Author

ctron commented Jul 14, 2016

I did amend the pull request so that the user now has the choice to select whether to include all Kura project (developer) or only the ones from the getting started tutorial (user).

Also does the setup now import all projects as Eclipse PDE projects (thanks to the Tycho Connector) and removed the unnecessary m2e settings from all child modules (see PR #323).

@ctron ctron changed the title Fix the package structure of "org.eclipse.soda.dk.comm" and add Ommph setup Provide Ommph setup and clean up build issues Jul 14, 2016
@kartben kartben changed the title Provide Ommph setup and clean up build issues Provide Oomph setup and clean up build issues Jul 18, 2016
This was referenced Jul 22, 2016
@dwoodard1
Copy link
Contributor

@ctron I recently merged a PR with very similar POM changes. Would it be possible for you to update this PR to include only the changes to support Ommph? It would be nice to have those changes isolated in one PR.

@ctron
Copy link
Contributor Author

ctron commented Jul 28, 2016

Yes, I will do that.

@ctron ctron force-pushed the develop branch 5 times, most recently from 371dddb to 0a0ab7b Compare July 28, 2016 14:58
This changes adds an Oomph based setup which follows the
"Getting Started" tutorial. It will allow the user to choose between
a minimal set as described in the tutorial or a full Kura developer
setup.

For this it was necessary to also fix a few project issues in order to
create a, mostly, error free workspace.
 
The steps to be taken for the end user are:

 * Install Java 8
 * Download and run the Eclipse installer
  * Select Eclipse IDE edition
  * Select "Eclipse Kura"
  * Enter location for installation
  * Wait a few minutes

In addition this change fixes a few project settings issues:

 * org.eclipse.soda.dk.comm package path (actually is
src/main/java/org/eclipse/soda/dk instead of
src/main/java/org/eclipse/soda/dk/comm)
 * Don't ignore Tycho and WTP maven plugins but install m2eclipse
adapters instead

Signed-off-by: Jens Reimann <jreimann@redhat.com>
@ctron
Copy link
Contributor Author

ctron commented Jul 28, 2016

So I cleaned up the PR. It is also rebased and the changes on the POM files got merged.

Regarding the POM files, which I changed as well. I did what the other PR did, but for the m2eclipse settings. First of all they can be at the parent project, as the other PR did it, and second several of them are not needed if you have the proper m2eclipse adapters installed, which the Oomph setup does.

In order for the Oomph setup pick up the projects types and create proper Eclipse projects, the m2eclipse "ignore" configuration must be removed.

In the case that you don't use the Oomph setup, a m2eclipse quick fix will allow you to install those connectors at a later time.

@dwoodard1 dwoodard1 merged commit e43ef56 into eclipse:develop Jul 28, 2016
@dwoodard1
Copy link
Contributor

@ctron Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants