Clean up base64 processing #695
Conversation
| */ | ||
| return new String(Base64.encodeBase64(encryptedBytes, false), "UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Instead of throwing generic Runtime Exception, it would be better off with KuraRuntimeException, in which you can specify the KuraErrorCode.
There was a problem hiding this comment.
I don't see a big difference, the exception will never ever be thrown and the whole try-catch will be gone with java 7 anyway.
There was a problem hiding this comment.
But if that should be a blocker, then I don't really care.
There was a problem hiding this comment.
Please replace with String(byte[] bytes, Charset charset) which does not throw exceptions
|
Since Kura 3.0.0 will only target Java 8, why not thinking of using only base64 java 8 primitives? Indirectly it was already used. And we don't need the dependency on commons.net. |
ctron
force-pushed
the
feature/fix_base64_1
branch
from
fddd979
to
1a50206
Compare
|
Updated to use Java 8 only. Rebased. |
ctron
force-pushed
the
feature/fix_base64_1
branch
from
1a50206
to
ee30fad
Compare
This change re-implements base64 processing by using standard Java 8 functionality. In addition a unit test was added to verify the same output as the old implementation. Signed-off-by: Jens Reimann <jreimann@redhat.com>
ctron
force-pushed
the
feature/fix_base64_1
branch
from
ee30fad
to
9a0743a
Compare
|
@MMaiero please vote |
This change forwards base 64 encoding to the already existing
dependency commons-net.
By re-using code from commons-net the reflection based method invocation
can be replaced by a proper method call.
In addition a unit test was added to verify the same output as the old
implementation.
Signed-off-by: Jens Reimann jreimann@redhat.com