Skip to content

Commit

Permalink
[tests] Fix NPE in MavenCompletionParticipantDuplicationTest
Browse files Browse the repository at this point in the history
```
java.lang.NullPointerException: Cannot invoke "String.toLowerCase(java.util.Locale)" because "version" is null
	at org.apache.maven.artifact.versioning.ComparableVersion.parseVersion(ComparableVersion.java:543)
	at org.apache.maven.artifact.versioning.ComparableVersion.<init>(ComparableVersion.java:534)
	at org.apache.maven.artifact.versioning.DefaultArtifactVersion.parseVersion(DefaultArtifactVersion.java:94)
	at org.apache.maven.artifact.versioning.DefaultArtifactVersion.<init>(DefaultArtifactVersion.java:44)
	at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipantDuplicationTest$1.compare(MavenCompletionParticipantDuplicationTest.java:116)
	at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipantDuplicationTest$1.compare(MavenCompletionParticipantDuplicationTest.java:111)
```
  • Loading branch information
vrubezhny committed Jul 7, 2023
1 parent c104ba0 commit ad1d478
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -29,7 +29,6 @@
import java.util.stream.Stream;

import org.apache.maven.artifact.versioning.DefaultArtifactVersion;
import org.eclipse.lemminx.XMLAssert;
import org.eclipse.lemminx.extensions.maven.searcher.RemoteCentralRepositorySearcher;
import org.eclipse.lemminx.extensions.maven.utils.MavenLemminxTestsUtils;
import org.eclipse.lemminx.services.XMLLanguageService;
Expand Down Expand Up @@ -112,8 +111,9 @@ public void testDuplicateCompletionVersionOrder() throws IOException, URISyntaxE
// Backward order
@Override
public int compare(CompletionItem o1, CompletionItem o2) {
return new DefaultArtifactVersion(o2.getSortText())
.compareTo(new DefaultArtifactVersion(o1.getSortText()));
String sortText1 = o1.getSortText() != null ? o1.getSortText() : o1.getLabel();
String sortText2 = o2.getSortText() != null ? o2.getSortText() : o2.getLabel();
return new DefaultArtifactVersion(sortText2).compareTo(new DefaultArtifactVersion(sortText1));
}
}).toList();
assertEquals(orderedCompletions, completions);
Expand Down

0 comments on commit ad1d478

Please sign in to comment.