Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report "Non-parseable POM" error #446

Closed
angelozerr opened this issue Jul 21, 2023 · 3 comments · Fixed by #447
Closed

Don't report "Non-parseable POM" error #446

angelozerr opened this issue Jul 21, 2023 · 3 comments · Fixed by #447
Assignees

Comments

@angelozerr
Copy link

When your XML has some syntax validation:

image

There is the error

Description	Resource	Path	Location	Type
Non-parseable POM C:\Users\azerr\eclipse-workspace-2023\test-xml\pom2.xml: unexpected character in markup   (position: START_TAG seen ...xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">\r\n    \r\n  < ... @5:5) 	pom2.xml	/test-xml	line 5	Language Servers

As it is a syntax error, it should not be reported, the syntax validation is managed correctly with LemMinx.

@mickaelistria
Copy link
Contributor

This would be very low priority; as it can still be useful to report errors like Maven would report them so people can refer to Maven error messages when trying to troubleshot things.

@angelozerr
Copy link
Author

For me it is a technical error that XML syntax is invalid and more the range is very strange. You have 2 errors in this case about syntax validation that LemMinx takes care, so IMHO it should be skipped.

vrubezhny added a commit to vrubezhny/lemminx-maven that referenced this issue Jul 21, 2023
vrubezhny added a commit that referenced this issue Jul 21, 2023
@vrubezhny vrubezhny self-assigned this Jul 21, 2023
@angelozerr
Copy link
Author

Thankss @vrubezhny !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants