Use String.replace instead of replaceAll when possible

Signed-off-by: Fred Bricon <fbricon@gmail.com>
eclipse · May 26, 2021 · db84e94 · db84e94
1 parent 8ca69a1
commit db84e94
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...lipse.lemminx/src/main/java/org/eclipse/lemminx/commons/snippets/SnippetDeserializer.java b/...lipse.lemminx/src/main/java/org/eclipse/lemminx/commons/snippets/SnippetDeserializer.java
@@ -108,10 +108,10 @@ public Snippet deserialize(JsonElement json, Type typeOfT, JsonDeserializationCo
 			String label = labelElt.getAsString();
 			if (label.contains("$")) {
 				if (!StringUtils.isEmpty(snippet.getDescription())) {
-					label = label.replaceAll("\\$description", snippet.getDescription());
+					label = label.replace("$description", snippet.getDescription());
 				}
 				if (!snippet.getPrefixes().isEmpty()) {
-					label = label.replaceAll("\\$prefix", snippet.getPrefixes().get(0));
+					label = label.replace("$prefix", snippet.getPrefixes().get(0));
 				}
 			}
 			snippet.setLabel(label);

diff --git a/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/FilesUtils.java b/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/utils/FilesUtils.java
@@ -272,6 +272,6 @@ public static Path getPath(String uri) {
 	 * @return the path with replaced spaces.
 	 */
 	public static String encodePath(String path) {
-		return path.replaceAll(" ", "%20");
+		return path.replace(" ", "%20");
 	}
 }
diff --git a/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/XMLAssert.java b/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/XMLAssert.java
@@ -943,8 +943,8 @@ public static LocationLink ll(final String uri, final Range originRange, Range t
 	public static void assertLocationLink(List<? extends LocationLink> actual, LocationLink... expected) {
 		assertEquals(expected.length, actual.size());
 		for (int i = 0; i < expected.length; i++) {
-			actual.get(i).setTargetUri(actual.get(i).getTargetUri().replaceAll("file:///", "file:/"));
-			expected[i].setTargetUri(expected[i].getTargetUri().replaceAll("file:///", "file:/"));
+			actual.get(i).setTargetUri(actual.get(i).getTargetUri().replace("file:///", "file:/"));
+			expected[i].setTargetUri(expected[i].getTargetUri().replace("file:///", "file:/"));
 		}
 		assertArrayEquals(expected, actual.toArray());
 	}