Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt linkedEditingRanges wordPattern property #1187

Closed
rgrunber opened this issue Mar 21, 2022 · 2 comments
Closed

Adopt linkedEditingRanges wordPattern property #1187

rgrunber opened this issue Mar 21, 2022 · 2 comments
Milestone

Comments

@rgrunber
Copy link
Contributor

rgrunber commented Mar 21, 2022

@vrubezhny mentioned that LemMinX doesn't use the wordPattern property to define when the linked editing range should exit the editing mode. I believe he ran into a case where the client (Eclipse?) had a different set of word patterns and there was some unexpected behaviour. I'll let him provide more details if needed.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#linkedEditingRanges

wordPattern value for some languages that may be associated with LemMinX
https://github.com/microsoft/vscode/blob/main/extensions/html/language-configuration.json#L35
https://github.com/microsoft/vscode/blob/main/extensions/xml/xml.language-configuration.json#L37

@angelozerr
Copy link
Contributor

Indeed vscode can use language configuration for wordpattern.

@vrubezhny any PR are welcome. We must just check that it doesnt break something on vscode side.

I suggest you too that you create an issue in vscode html language service github project to support wordpattern on html ls side

vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Mar 25, 2022
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue Mar 31, 2022
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
mickaelistria pushed a commit that referenced this issue Mar 31, 2022
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@angelozerr angelozerr modified the milestones: 0.20.0, 0.20.1 Apr 1, 2022
@angelozerr
Copy link
Contributor

angelozerr commented Apr 4, 2022

Fixed with #1187

Thanks @vrubezhny !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants