Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for textDocument/definition for XML Schema #148

Closed
fbricon opened this issue Sep 26, 2018 · 5 comments · Fixed by #450
Closed

Add support for textDocument/definition for XML Schema #148

fbricon opened this issue Sep 26, 2018 · 5 comments · Fixed by #450
Assignees
Labels
enhancement New feature or request hyperlink XSD
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 26, 2018

So that you can navigate from an element to its type definition in a schema.
Suggested by @ifedorenko.

@fbricon fbricon added the enhancement New feature or request label Sep 26, 2018
@angelozerr
Copy link
Contributor

I love this idea, but I'm afraid that it's an hard work. @ifedorenko is there any chance that you could work on this feature? If yes, tell me and I will initialize support extension for definition, that you will able to implement it in extensions/contentmodel.

@ifedorenko
Copy link

no, I do not currently plan to work on this enhancement.

@angelozerr
Copy link
Contributor

no, I do not currently plan to work on this enhancement.

Ok thanks for your answer. I have initialized the definition participant.

@fbricon fbricon added this to the v0.0.3 milestone Nov 3, 2018
@angelozerr
Copy link
Contributor

I would like to try to manage those defintion type with XPath with #168. The idea is just to declare references with Xpath between type, ex :

from="//*:extension/@base"
to="//*:complexType/@name"

If we take this sample

<xs:element name="employee" type="fullpersoninfo"/>

<xs:complexType name="personinfo">
  <xs:sequence>
    <xs:element name="firstname" type="xs:string"/>
    <xs:element name="lastname" type="xs:string"/>
  </xs:sequence>
</xs:complexType>

<xs:complexType name="fullpersoninfo">
  <xs:complexContent>
    <xs:extension base="personinfo">
      <xs:sequence>
        <xs:element name="address" type="xs:string"/>
        <xs:element name="city" type="xs:string"/>
        <xs:element name="country" type="xs:string"/>
      </xs:sequence>
    </xs:extension>
  </xs:complexContent>
</xs:complexType>

the below XPath from/to declaration will manage

  • completion
  • hyperlink
  • references
  • validation

@fbricon fbricon modified the milestones: v0.0.3, v0.0.4 Nov 15, 2018
@NikolasKomonen NikolasKomonen modified the milestones: v0.4.0, v0.5.0 Mar 1, 2019
@NikolasKomonen NikolasKomonen removed this from the v0.5.0 milestone Mar 15, 2019
@angelozerr angelozerr changed the title Add support for textDocument/definition Add support for textDocument/definition for XML Schema May 14, 2019
angelozerr added a commit that referenced this issue Jun 19, 2019
Fix #148

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jun 19, 2019
Fix #148

This PR manage the following definition only in the XML Schema (external
definition is not managed):

 - xs:element/@type -> xs:complexType/@name
 - xs:extension/@base -> xs:complexType/@name

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jun 20, 2019
Fix #148

This PR manage the following definition only in the XML Schema (external
definition is not managed):

 - xs:element/@type -> xs:complexType/@name
 - xs:extension/@base -> xs:complexType/@name

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr added this to the v0.8.0 milestone Jun 20, 2019
NikolasKomonen pushed a commit that referenced this issue Jun 20, 2019
Fix #148

This PR manage the following definition only in the XML Schema (external
definition is not managed):

 - xs:element/@type -> xs:complexType/@name
 - xs:extension/@base -> xs:complexType/@name

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor

Thank's @NikolasKomonen for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hyperlink XSD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants