Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow code actions to be created if no Diagnostics is provided #1516

Closed
vrubezhny opened this issue May 3, 2023 · 0 comments · Fixed by #1517
Closed

Allow code actions to be created if no Diagnostics is provided #1516

vrubezhny opened this issue May 3, 2023 · 0 comments · Fixed by #1517
Assignees
@vrubezhny
Milestone
0.26.0

Comments

@vrubezhny
Copy link
Contributor

Currently org.eclipse.lemminx.services.XMLCodeActions.doCodeActions(CodeActionContext, Range, DOMDocument, SharedSettings, CancelChecker) requires a Diagnostics to be explicitly set in CodeActionContext in order to acquire code actions from ICodeActionParticipant' -s defined.

This doesn't allow the creation of CodeAction -s that do not require any error/warning/info/etc. diagnostic for a document range, like, for example, for refactoring or code snippets.

In order to allow the creation of code actions for any document position (even if there is no any diagnostic is created for such a position) we need to make diagnostics to be optional in XMLCodeActions.doCodeActions(...)
@vrubezhny vrubezhny mentioned this issue May 3, 2023
Closed
@vrubezhny vrubezhny self-assigned this May 3, 2023
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 8, 2023
@vrubezhny
Allow code actions to be created if no Diagnostics is provided eclips…
2a7dcaf 
…e#1516
@vrubezhny vrubezhny linked a pull request May 8, 2023 that will close this issue
Allow code actions to be created if no Diagnostics is provided #1516 #1517
Merged
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 9, 2023
@vrubezhny
Allow code actions to be created if no Diagnostics is provided eclips…
0569b59 
…e#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 9, 2023
@vrubezhny
Allow code actions to be created if no Diagnostics is provided eclips…
0d76910 
…e#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 9, 2023
@vrubezhny
Allow code actions to be created if no Diagnostics is provided eclips…
91a65ea 
…e#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 10, 2023
@vrubezhny
Allow code actions to be created if no Diagnostics is provided eclips…
203c931 
…e#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 10, 2023
@vrubezhny
Allow code actions to be created if no Diagnostics is provided eclips…
f6f72cb 
…e#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 10, 2023
@vrubezhny
Allow code actions to be created if no Diagnostic is provided eclipse…
68f723d 
…#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 11, 2023
@vrubezhny
Allow code actions to be created if no Diagnostic is provided eclipse…
f409ced 
…#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 11, 2023
@vrubezhny
Allow code actions to be created if no Diagnostic is provided eclipse…
3053241 
…#1516
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 15, 2023
@vrubezhny
Allow code actions to be created if no Diagnostic is provided eclipse…
ab6533f 
…#1516
angelozerr pushed a commit that referenced this issue May 15, 2023
@vrubezhny @angelozerr
Allow code actions to be created if no Diagnostic is provided #1516
13099ea
@vrubezhny vrubezhny added this to the 0.26.0 milestone Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
None yet
Projects
None yet
Milestone
0.26.0
Development

Successfully merging a pull request may close this issue.

Allow code actions to be created if no Diagnostics is provided #1516 vrubezhny/lemminx
1 participant
@vrubezhny