Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion for locally declared entity #520

Closed
angelozerr opened this issue Jul 18, 2019 · 4 comments · Fixed by #659
Closed

Completion for locally declared entity #520

angelozerr opened this issue Jul 18, 2019 · 4 comments · Fixed by #659
Assignees
Labels
completion This issue or enhancement is related to completion support DTD enhancement New feature or request
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Jul 18, 2019

Completion for declared entity

Given this XML file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY mdash "&#x2014;">
]>
<root>
  |
</root>

It should be cool to have completion on [ to show mdash entity. When it will be inserted, it must generate &mdash ;

@angelozerr angelozerr added completion This issue or enhancement is related to completion support DTD labels Nov 2, 2019
@ph777
Copy link

ph777 commented Mar 25, 2020

Any plans to support this? It would be great help.

@angelozerr angelozerr self-assigned this Apr 2, 2020
@fbricon fbricon added the enhancement New feature or request label Apr 22, 2020
@fbricon fbricon added this to the 0.12.0 milestone Apr 22, 2020
@fbricon fbricon changed the title Completion for declared entity Completion for locally declared entity Apr 22, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 24, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

@ph777 I'm working on this issue, but it will work for only local entities. Is it a feature which could help you or not? I think you wish to have completion on external DTD but I wanted just to know if local completion entity could be helpful for you.

angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 24, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 25, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 25, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 25, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 26, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
@ph777
Copy link

ph777 commented Apr 26, 2020 via email

angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 27, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 27, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 27, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Apr 27, 2020
Fixes eclipse#520

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

We would appretiate if both worked. However, improvement on local entities is also a
valuable improvement ;-)

Ok thanks for your feedback.

Is it hard to also do external entities?

I don't know, I need to investigate Xerces support for that, see #660

angelozerr pushed a commit that referenced this issue Apr 27, 2020
Fixes #520

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion This issue or enhancement is related to completion support DTD enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants