Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for completionItem/resolve #616

Closed
mickaelistria opened this issue Mar 7, 2020 · 4 comments · Fixed by #1234
Closed

Support for completionItem/resolve #616

mickaelistria opened this issue Mar 7, 2020 · 4 comments · Fixed by #1234
Assignees
Labels
performance This issue or enhancement is related to performance concerns
Milestone

Comments

@mickaelistria
Copy link
Contributor

For Maven extension, we'd like to offer completion item documentation asynchronously (as it requires to read the pom which we cannot do for all proposals or completion would take to long).
Does the extension provide a way to "resolve" a completion item? I couldn't find an appropriate method.

@mickaelistria mickaelistria changed the title How to contribute to completionItem/resolve How to contribute to completionItem/resolve ? Mar 7, 2020
@angelozerr
Copy link
Contributor

angelozerr commented Mar 7, 2020

No there is no possibility to do that, because today we need not that (performance are correct for any extension like XSD, DTD completion, etc).

Any contribution are welcome!

To do that, I suggest that you implement completion/resolve like

public CompletableFuture<Either<List<CompletionItem>, CompletionList>> completion(CompletionParams params) {

The XMLLanguageService should have a new method like doResolveCompletionItem which call the same method in https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLCompletions.java

The doResolveCompletionItem must loop for ICompletionParticipant like

for (ICompletionParticipant participant : getCompletionParticipants()) {
and call the new method ICompletionParticipant #resolveCompletionItem (by default it should return null)

It's the main idea, if you need some more help, please ask me.

@mickaelistria
Copy link
Contributor Author

This has become more important in lemminx-maven since adoption of Maven Central Search engine that doesn't provide description in its response; so we need to download the pom to show description and this shoudl be part of a completionItem/resolve.
cc @vrubezhny

@angelozerr
Copy link
Contributor

Any contribution are welcome!

@angelozerr
Copy link
Contributor

We need this resolve completion support to fix redhat-developer/vscode-xml#679

@datho7561 datho7561 self-assigned this Jun 8, 2022
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 22, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 22, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 22, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 22, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 22, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 22, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 23, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 23, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 23, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Jun 23, 2022
Collect model documentation for completion items in the resolve step

Fixes eclipse#616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Jun 27, 2022
Collect model documentation for completion items in the resolve step

Fixes #616, redhat-developer/vscode-xml#679

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.21.0 milestone Jun 27, 2022
@angelozerr angelozerr added the performance This issue or enhancement is related to performance concerns label Jun 29, 2022
@angelozerr angelozerr changed the title How to contribute to completionItem/resolve ? Support for completionItem/resolve Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance This issue or enhancement is related to performance concerns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants