Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickfix to close open tag doesn't deal with attributes #646

Closed
fbricon opened this issue Apr 20, 2020 · 0 comments · Fixed by #760 or enxio/lsp4xml#59
Closed

Quickfix to close open tag doesn't deal with attributes #646

fbricon opened this issue Apr 20, 2020 · 0 comments · Fixed by #760 or enxio/lsp4xml#59
Assignees
@angelozerr
Labels
bug Something isn't working code action
Milestone
0.12.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Apr 20, 2020

Try to apply any of the proposed quickfixes to

<foo>
  <bar action="toot" /
</foo>

Apr-20-2020 16-59-03

None generate proper code. I reckon it might be tricky to fix though
@angelozerr angelozerr added bug Something isn't working code action labels Apr 20, 2020
@angelozerr angelozerr self-assigned this Apr 20, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 2, 2020
Quickfix to close open tag doesn't deal with attributes
366d88e 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 2, 2020
Quickfix to close open tag doesn't deal with attributes
26173b2 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jun 2, 2020
Merged
@angelozerr angelozerr added this to the 0.12.0 milestone Jun 3, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 3, 2020
Quickfix to close open tag doesn't deal with attributes
2b47b3a 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 3, 2020
Quickfix to close open tag doesn't deal with attributes
7bc6501 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 3, 2020
Quickfix to close open tag doesn't deal with attributes
9166feb 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 3, 2020
Quickfix to close open tag doesn't deal with attributes
55a2288 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
Quickfix to close open tag doesn't deal with attributes
5aadbfd 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
Quickfix to close open tag doesn't deal with attributes
bab7449 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
Quickfix to close open tag doesn't deal with attributes
c97d217 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
Quickfix to close open tag doesn't deal with attributes
a1ea5bd 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
Quickfix to close open tag doesn't deal with attributes
6de6f97 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 4, 2020
Quickfix to close open tag doesn't deal with attributes
026f521 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Jun 5, 2020
Quickfix to close open tag doesn't deal with attributes
e417a51 
Fixes eclipse#646

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Jun 5, 2020
@angelozerr
Quickfix to close open tag doesn't deal with attributes
5082892 
Fixes #646

Signed-off-by: azerr <azerr@redhat.com>
@enxio enxio mentioned this issue Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working code action
Projects
None yet
Milestone
0.12.0
2 participants
@fbricon @angelozerr