Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in ContentModelCodeActionParticipant.doCodeAction#L47 #671

Closed
fbricon opened this issue May 3, 2020 · 1 comment · Fixed by #747
Closed

NPE in ContentModelCodeActionParticipant.doCodeAction#L47 #671

fbricon opened this issue May 3, 2020 · 1 comment · Fixed by #747
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
0.12.0

Comments

@fbricon
Copy link
Contributor

fbricon commented May 3, 2020

I'm not able to reproduce, so I don't understand how it occured, but I saw some NPEs in

lemminx/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/contentmodel/participants/ContentModelCodeActionParticipant.java

Line 47 in f12cf5d

if (!diagnostic.getCode().isLeft()) {

@fbricon fbricon added the bug Something isn't working label May 3, 2020
@fbricon fbricon added this to the 0.12.0 milestone May 3, 2020
@fbricon fbricon added the good first issue Good for newcomers label May 5, 2020
@fbricon
Copy link
Contributor Author

fbricon commented May 29, 2020

@datho7561 please add a test case checking the NPE occurs when diagnostic has no code, then add the null check in doCodeAction()

datho7561 added a commit to datho7561/lemminx that referenced this issue May 29, 2020
@datho7561
Make ContentModelCodeActionParticipant null-resilient
b12c80a 
Fixes eclipse#671

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue May 29, 2020
Merged
datho7561 added a commit to datho7561/lemminx that referenced this issue May 29, 2020
@datho7561
Make ContentModelCodeActionParticipant null-resilient
a5de287 
Fixes eclipse#671

Signed-off-by: David Thompson <davthomp@redhat.com>
fbricon pushed a commit that referenced this issue May 29, 2020
@datho7561 @fbricon
Make ContentModelCodeActionParticipant null-resilient
f2a90dd 
Fixes #671

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Mar 4, 2022
Arbitrary File Read
d221082 
Fixes eclipse#671

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Make ContentModelCodeActionParticipant null-resilient datho7561/lemminx
1 participant
@fbricon