Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xml-model] Snippet to generate xml-model #699

Closed
angelozerr opened this issue May 13, 2020 · 5 comments · Fixed by #752
Closed

[xml-model] Snippet to generate xml-model #699

angelozerr opened this issue May 13, 2020 · 5 comments · Fixed by #752
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request good first issue Good for newcomers snippet xml-model
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented May 13, 2020

Snippet to generate xml-model and their attributes (with choice). See https://www.w3.org/XML/2010/01/xml-model/

To do that:

  • rename prolog-snippets.json to processing-instruction-snippets.json
  • write xml-model snippets in processing-instruction-snippets.json.
@angelozerr angelozerr added the completion This issue or enhancement is related to completion support label May 13, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone May 13, 2020
@angelozerr angelozerr added the good first issue Good for newcomers label May 13, 2020
@BalduinLandolt
Copy link
Contributor

I'll give that a go, if that's allright and no one is working on it already?

@angelozerr
Copy link
Contributor Author

@datho7561 should work on this issue, but i think he has not started it. @datho7561 if you have not started something, are you OK to delegate this issue to @BalduinLandolt ?

@datho7561
Copy link
Contributor

datho7561 commented May 27, 2020 via email

@angelozerr
Copy link
Contributor Author

I haven't started working on this issue, and I'm okay with @BalduinLandot working on it.

Thanks @datho7561 for your answer.

@BalduinLandolt any contribution are welcome! I think we should have a snippets with required attribute like href and another (one or several) snippets with other attributes. Some attributes like schematypens should be declared as choice to have a list of values.

@BalduinLandolt
Copy link
Contributor

Allright then. :)

In fact, I'd rather leave the prolog snippet as it is, and make processing insructions a separate on. That is for two reasons:

  1. the prolog is technically not a PI (see Rename "processing instruction" snippet to "xml declaration" #727)
  2. the PIs have different rules, where they can be triggered: the prolog can basically only be in the first position. the PIs can be everywhere before the root element, except before the prolog.

... unless, of course, there are objections to that?
I'll just give it a go, and then draft a PR. If you don't like it, you'll see that right away, there.

This was referenced May 27, 2020
angelozerr pushed a commit that referenced this issue May 31, 2020
Adjust unit tests accordingly.

Fixes #699.

Signed-off-by: Balduin Landolt <balduin.landolt@hotmail.com>
@xorye xorye added the enhancement New feature or request label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request good first issue Good for newcomers snippet xml-model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants