Adjust range for XML schema errors

[angelozerr]

No description provided.

[fbricon]

@angelozerr what's the status on this one?

[angelozerr]

It's not finished. The long task is to write tests (and find usecase).

[fbricon]

The IBM XML language server has a bunch of test samples that we can use for validating our solution.

We can see that our diagnostic ranges look bad:

@angelozerr is this something you're still working on or should I ask @NikolasKomonen to take over?

[fbricon]

Same file validated with IBM's server:

[angelozerr]

Thanks for the info @fbricon I will try to improve this range problem.

[angelozerr]

@fbricon I have managed selection of error date, but I have not written test. Do you think we can use the IBM Language Server invoice.xsd to write test?

[fbricon]

I guess you can. Project is EPL. In doubt you can easily create a simple schema with dates

[fbricon]

So we made some progress but I still see bad ranges at the end of problematic nodes:

[angelozerr]

I guess you can. Project is EPL. In doubt you can easily create a simple schema with dates

Ok thanks, I will create a new file for that according your suggestion

So we made some progress but I still see bad ranges at the end of problematic nodes:

Yes I know that, the error is for cvc-datatype-valid.1.2.1 (I seems that the Xerces version of IBM Language server doesn't manage it).

The sample at https://wiki.xmldation.com/Support/Validator/cvc-datatype-valid-1-2-1 is for element text, but I tell me if for attribute value we can have this error too? I had implemented that in https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/contentmodel/participants/XMLSchemaErrorCode.java#L120 (but it's commented). I would like to check if we can hav ethis error for attribute value. Once I will check it, I will write tests for that.

[angelozerr]

@fbricon now we should have the same thing than IBM XML Language Server.

[fbricon]

Still seeing bad ranges for invalid attributes content (closing bracket is underlined):

[angelozerr]

Now it should be better.

[fbricon]

Nope. Still seeing underline on closing bracket. Range is still wrong:

[angelozerr]

Nope. Still seeing underline on closing bracket. Range is still wrong:

Are you sure that you are using version from master? Test are https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/contentmodel/XMLSchemaDiagnosticsTest.java#L136

[fbricon]

yes, that's why I made #139, to be sure about the version running

[angelozerr]

Sorry @fbricon there were indeed a bug that it should be fixed. Sorry again -(

[fbricon]

Works now! Thanks @angelozerr !
Are we still missing anything to close this issue?

[angelozerr]

Works now! Thanks @angelozerr !

Cool!

Are we still missing anything to close this issue?

I think we can close this issue. I have managed the same adjust ranges than WTP, but as you have seen it missed some case that WTP doesn't manage. I hope we have the same feature than IBM Language Server.

I propose you to close this issue and if we find new bugs, we could create a new issue with the given problem.

[fbricon]

Fair enough. closing

[angelozerr]

@fbricon just for your information, I have played with the XML IBM XML Server and I have fixed few problems with completions and improve code actions.

Here the code actions which are available:

and here completion for attribute name:

and for attribute value:

The completion on attribute value is bugged when you fill the value, apply value is not well done.