Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity documentation has no value for entities declared with SYSTEM OR PUBLIC #741

Closed
xorye opened this issue May 28, 2020 · 2 comments · Fixed by #746
Closed

Entity documentation has no value for entities declared with SYSTEM OR PUBLIC #741

xorye opened this issue May 28, 2020 · 2 comments · Fixed by #746
Assignees
@angelozerr
Labels
bug Something isn't working DTD
Milestone
0.12.0

Comments

@xorye
Copy link

xorye commented May 28, 2020

With this XML

<?xml version="1.0" standalone="no" ?>
<!DOCTYPE copyright [
  <!ELEMENT copyright (#PCDATA)>
  <!ENTITY c SYSTEM "http://www.xmlwriter.net/copyright.xml">
]>
<copyright>&c;</copyright>

The hover does not show the value of c:
image

The same thing happens if we have
<!ENTITY c PUBLIC "http://www.xmlwriter.net/copyright.xml">
instead of
<!ENTITY c SYSTEM "http://www.xmlwriter.net/copyright.xml">

It would be great if the entity's value ("http://www.xmlwriter.net/copyright.xml" in this case) was displayed in the documentation.
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
b36f792 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
b27cdba 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue May 29, 2020
Merged
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
e79b08e 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this May 29, 2020
@angelozerr angelozerr added bug Something isn't working DTD labels May 29, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone May 29, 2020
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
5125e3b 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
0f6d541 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
eff8de5 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
9566113 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
41b1c37 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
5435630 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 29, 2020
Entity documentation has no value for entities declared with SYSTEM OR
0723e3b 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/lemminx that referenced this issue May 30, 2020
Entity documentation has no value for entities declared with SYSTEM OR
26b8407 
PUBLIC

Fixes eclipse#741

Signed-off-by: azerr <azerr@redhat.com>
@fbricon
Copy link
Contributor

fbricon commented May 30, 2020

Is this the expected result?

Screen Shot 2020-05-30 at 9 30 10 PM

http://www.xmlwriter.net/copyright.xml doesn't exist. Does it change anything, isn't it supposed to be actually read for the actual entity resolution?

@angelozerr
Copy link
Contributor

I need to Read spécification but xerces doesnt report error with entity copyright so i think its a vazlid entity. For résolution support please create an issue

fbricon pushed a commit that referenced this issue Jun 1, 2020
@fbricon
Entity documentation has no value for entities declared with SYSTEM OR
374ea32 
PUBLIC

Fixes #741

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working DTD
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Entity documentation has no value for entities declared with SYSTEM OR PUBLIC angelozerr/lemminx
3 participants
@fbricon @angelozerr @xorye