Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML catalog nextCatalog/@catalog documentLink support. #845

Closed
angelozerr opened this issue Aug 18, 2020 · 1 comment · Fixed by #884 or enxio/lsp4xml#85
Closed

XML catalog nextCatalog/@catalog documentLink support. #845

angelozerr opened this issue Aug 18, 2020 · 1 comment · Fixed by #884 or enxio/lsp4xml#85
Assignees
@datho7561
Labels
catalog enhancement New feature or request hyperlink
Milestone
0.14.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Aug 18, 2020 •
edited

Given this XML catalog:

<catalog xmlns="urn:oasis:names:tc:entity:xmlns:xml:catalog">

  <nextCatalog catalog="plugins/org.dita.base/catalog-dita.xml"/>

</catalog>

This sample comes from catalog-dita.xml from https://github.com/dita-ot/dita-ot/releases/download/3.5.1/dita-ot-3.5.1.zip

It should be nice to have hyperlink for nextCatalog /@catalog attribute
@datho7561
Copy link
Contributor

I would be interested in working on this. Ideally, all the elements that refer to another catalog (have a catalog attribute that's a URI) that are defined in the catalog schema should have document links. These are:

  • delegatePublic
  • delegateSystem
  • delegateUri
  • nextCatalog

Reference to the catalog XSD schema

@datho7561 datho7561 self-assigned this Sep 10, 2020
@fbricon fbricon added the enhancement New feature or request label Sep 17, 2020
@fbricon fbricon closed this as completed Sep 17, 2020
@datho7561 datho7561 reopened this Sep 17, 2020
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 22, 2020
@datho7561
Doclink for catalog entries with 'catalog' attr
906e57e 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Closes eclipse#845

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Sep 22, 2020
Merged
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 23, 2020
@datho7561
Doclink for catalog entries with 'catalog' attr
4ee22d1 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Closes eclipse#845

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 23, 2020
@datho7561
Doclink for catalog entries with 'catalog' attr
1f1ff7b 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Closes eclipse#845

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 23, 2020
@datho7561
Doclink for catalog entries with 'catalog' attr
8a29349 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Closes eclipse#845

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 24, 2020
@datho7561
Doclink for catalog entries with 'catalog' attr
445758f 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Closes eclipse#845

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.14.0 milestone Sep 25, 2020
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 30, 2020
@datho7561
Doclink for catalog entries with 'catalog' attr
9e78d66 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Use xml:base when making catalog doc links

Doc links now work inside `<group></group>`.
xml:base is taken into account when calculating where a doc link should
point in catalog files.

Closes eclipse#845

Signed-off-by: David Thompson <davthomp@redhat.com>
angelozerr pushed a commit that referenced this issue Sep 30, 2020
@datho7561 @angelozerr
Doclink for catalog entries with 'catalog' attr
dbf43f3 
Any of the catalog entry elements that have the 'catalog' attribute
to refer to another catalog are now doclinks.

Use xml:base when making catalog doc links

Doc links now work inside `<group></group>`.
xml:base is taken into account when calculating where a doc link should
point in catalog files.

Closes #845

Signed-off-by: David Thompson <davthomp@redhat.com>
@enxio enxio mentioned this issue Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
catalog enhancement New feature or request hyperlink
Projects
None yet
Milestone
0.14.0
3 participants
@fbricon @angelozerr @datho7561