Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error range for empty element cvc-datatype-valid.1.2.3 #871

Closed
datho7561 opened this issue Sep 10, 2020 · 0 comments · Fixed by #872
Closed

Error range for empty element cvc-datatype-valid.1.2.3 #871

datho7561 opened this issue Sep 10, 2020 · 0 comments · Fixed by #872
Assignees
@datho7561
Labels
bug Something isn't working validation
Milestone
0.14.0

Comments

@datho7561
Copy link
Contributor

If an element has a union type, cvc-datatype-valid.1.2.3 is issued. This PR fixed the error range. However, if the content is empty, the incorrect range is selected:

cvc123oops

Instead of the closing angle brace of the closing tag, the entire element should be highlighted.
@datho7561 datho7561 self-assigned this Sep 10, 2020
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 10, 2020
@datho7561
Fix error range for cvc-123 on empty content
eb22a4a 
Closes eclipse#871

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Sep 10, 2020
Merged
datho7561 added a commit to datho7561/lemminx that referenced this issue Sep 11, 2020
@datho7561
Fix error range for cvc-123 on empty content
50d44ad 
Underlines the element name in the start tag if the content of the
element is empty.

Closes eclipse#871

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 modified the milestone: 0.14.0 Sep 11, 2020
angelozerr pushed a commit that referenced this issue Sep 12, 2020
@datho7561 @angelozerr
Fix error range for cvc-123 on empty content
e617a42 
Underlines the element name in the start tag if the content of the
element is empty.

Closes #871

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr added this to the 0.14.0 milestone Sep 12, 2020
@angelozerr angelozerr added the bug Something isn't working label Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working validation
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Fix error range for cvc-123 on empty content datho7561/lemminx
2 participants
@angelozerr @datho7561