Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error range for ETagUnterminated #875

Closed
angelozerr opened this issue Sep 16, 2020 · 2 comments · Fixed by #877
Closed

Improve error range for ETagUnterminated #875

angelozerr opened this issue Sep 16, 2020 · 2 comments · Fixed by #877
Assignees
Labels
bug Something isn't working validation
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Sep 16, 2020

Given this XML file:

<?xml version='1.0' encoding='UTF-8'?>
<project>
  <dependencies>
    <dependency>
      <scope>test</scope>
    </dependency
    <dependency>
      <scope>test</scope>
    </dependency>
  </dependencies>
</project>

The error highlight scope element:

image

although it should higlight the dependency element like:

image

Another usecase:

<foo>
  <ba><ABCD></ABCD></bar>
</foo>

bar should be highlighted, but we have that:

image

@angelozerr angelozerr added bug Something isn't working validation labels Sep 16, 2020
@angelozerr angelozerr added this to the 0.14.0 milestone Sep 16, 2020
@angelozerr angelozerr self-assigned this Sep 16, 2020
@fbricon
Copy link
Contributor

fbricon commented Sep 16, 2020

Weird, cause it works in other cases
Screen Shot 2020-09-16 at 12 14 24 PM

@angelozerr
Copy link
Contributor Author

Weird, cause it works in other cases

Yes I know, we support error range for ETagUnterminated, but there are some usecases (described in the issue) which doesn't work. I started to investigate the problem, hope I could create a PR soon.

angelozerr pushed a commit to angelozerr/lemminx that referenced this issue Sep 16, 2020
Fixes eclipse#875

Signed-off-by: azerr <azerr@redhat.com>
datho7561 pushed a commit that referenced this issue Sep 16, 2020
Fixes #875

Signed-off-by: azerr <azerr@redhat.com>

Co-authored-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants