Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go To References in binary #1059

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fix Go To References in binary #1059

merged 1 commit into from
Jun 17, 2021

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented Jun 17, 2021 •
edited

Closes redhat-developer/vscode-xml#513

Signed-off-by: David Thompson davthomp@redhat.com

@datho7561
Fix Go To References in binary
07cc296 
Closes redhat-develoepr/vscode-xml#513

Signed-off-by: David Thompson <davthomp@redhat.com>
rgrunber
rgrunber approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me. Also noted that selecting the codelens entry itself did work before.

@datho7561 datho7561 merged commit 13a9508 into eclipse:master Jun 17, 2021
@datho7561 datho7561 deleted the 513-show-reference-reflection branch June 17, 2021 15:12
@fbricon fbricon added bug Something isn't working references labels Jun 17, 2021
@fbricon fbricon added this to the 0.17.0 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
bug Something isn't working references reflection
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Error in show reference request when using binary
3 participants
@datho7561 @rgrunber @fbricon