Aggregate errors in xsd:import|include@schemaLocation for referenced grammar which have errors #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
xsd-aggregate-errors
branch
2 times, most recently
from
aaa0ac8
to
e3942b2
Compare
|
This PR fixes
The PR can be tested, I need to write tests and after that I will swith to real PR. |
angelozerr
changed the title
angelozerr
force-pushed
the
xsd-aggregate-errors
branch
from
e3942b2
to
aa4137a
Compare
Mooninaut
reviewed
Sep 30, 2021
...c/main/java/org/eclipse/lemminx/extensions/contentmodel/participants/XMLSchemaErrorCode.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
xsd-aggregate-errors
branch
2 times, most recently
from
ce5fc6f
to
30cf4a2
Compare
grammar which have errors Fixes redhat-developer/vscode-xml#596 Signed-off-by: azerr <azerr@redhat.com>
|
@rgrunber I have written test, you can review it now. |
|
The change works for me, and I don't see any errors that are related so I would feel free to merge. |
|
@rgrunber thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate errors in xsd:import|include@schemaLocation for referenced grammar which have errors
Fixes redhat-developer/vscode-xml#596
Signed-off-by: azerr azerr@redhat.com