Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the HTTP proxy configuration for HTTPS as well #1253

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Use the HTTP proxy configuration for HTTPS as well #1253

merged 1 commit into from
Jul 19, 2022

Conversation

datho7561
Copy link
Contributor

Signed-off-by: David Thompson davthomp@redhat.com

rgrunber
rgrunber approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. We're just re-using the same proxy address for http & https.

@datho7561 datho7561 marked this pull request as ready for review July 15, 2022 14:34
@datho7561 datho7561 added the enhancement New feature or request label Jul 15, 2022
@datho7561 datho7561 added this to the 0.22.0 milestone Jul 15, 2022
@datho7561
Use proxy config as HTTPS proxy as well
c8e38aa 
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 735-accept-https-proxy-from-env branch from 6dffe7a to c8e38aa Compare July 15, 2022 14:39
@datho7561 datho7561 requested a review from rgrunber July 15, 2022 14:39
rgrunber
rgrunber approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to bump to 0.22.0 as we already have some improvements to the experimental formatter for the upcoming release.

@datho7561 datho7561 merged commit bcad686 into eclipse:master Jul 19, 2022
@datho7561 datho7561 deleted the 735-accept-https-proxy-from-env branch July 19, 2022 15:28
@angelozerr angelozerr changed the title Use proxy config as HTTPS proxy as well Use the same proxy configuration for HTTPS Oct 17, 2022
@angelozerr angelozerr changed the title Use the same proxy configuration for HTTPS Use the HTTP proxy configuration for HTTPS as well Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@datho7561 @rgrunber