Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins and GH Actions build scripts to reflect branch renaming #1261

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

rgrunber
Copy link
Contributor

  • Renaming 'master' branch to 'main'
  • Update corresponding documentation

Signed-off-by: Roland Grunberg rgrunber@redhat.com

This change would depend on the renaming being done via. GH settings beforehand.

@rgrunber
Copy link
Contributor Author

CC'ing @datho7561 to have a look in case we've missed something.

I think the JIRO job at https://ci.eclipse.org/lemminx/job/lemminx/ , should just update once these changes are made assuming it takes its name from the branch configured in the Jenkinsfile.

@rgrunber
Copy link
Contributor Author

@datho7561
Copy link
Contributor

A few other occurences that are important:

public static final String MAIN_BRANCH = "master";

assertFalse(details.contains(branch), "master branch should not be in the details");

https://github.com/eclipse/lemminx/blob/main/README.md?plain=1#L3

- Renaming 'master' branch to 'main'
- Update corresponding documentation
- Update logic that parses the git resource bundle

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@datho7561 datho7561 added enhancement New feature or request build labels Jul 26, 2022
@datho7561 datho7561 added this to the 0.22.0 milestone Jul 26, 2022
@datho7561 datho7561 merged commit dea47eb into eclipse:main Jul 26, 2022
@rgrunber rgrunber deleted the rename-to-main branch July 26, 2022 20:00
@angelozerr angelozerr removed the enhancement New feature or request label Sep 28, 2022
@angelozerr angelozerr changed the title Update Jenkins and GH Actions build scripts for branch renaming Update Jenkins and GH Actions build scripts to reflect branch renaming Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants