Fix tests on Windows OS #1306
Merged
Fix tests on Windows OS #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
fix-test-windows-os
branch
4 times, most recently
from
bd88a93
to
f3a9403
Compare
|
@JessicaJHee @datho7561 I need to clean some part of code, but if you have time, please review it. Thanks! |
angelozerr
force-pushed
the
fix-test-windows-os
branch
2 times, most recently
from
fe74832
to
4d6f561
Compare
|
Tests fail on Linux |
angelozerr
force-pushed
the
fix-test-windows-os
branch
from
4d6f561
to
03f91ea
Compare
My bad, I forgot to fix XSI formatter. Let's me study that. |
angelozerr
force-pushed
the
fix-test-windows-os
branch
2 times, most recently
from
05c711a
to
1fbd721
Compare
|
@datho7561 tests should be fixed now. |
JessicaJHee
approved these changes
Oct 3, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMTextFormatter.java
Outdated
Show resolved
Hide resolved
...eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMAttributeFormatter.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMElementFormatter.java
Outdated
Show resolved
Hide resolved
datho7561
reviewed
Oct 3, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMDocTypeFormatter.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
fix-test-windows-os
branch
5 times, most recently
from
5ca035f
to
001b27e
Compare
datho7561
requested changes
Oct 4, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMElementFormatter.java
Outdated
Show resolved
Hide resolved
...lipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/XMLFormatterDocumentNew.java
Outdated
Show resolved
Hide resolved
...lipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/XMLFormatterDocumentNew.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
fix-test-windows-os
branch
from
001b27e
to
7adfd4d
Compare
datho7561
reviewed
Oct 4, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/TextEditUtils.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
fix-test-windows-os
branch
2 times, most recently
from
bcc657d
to
000aebc
Compare
Signed-off-by: azerr <azerr@redhat.com>
datho7561
approved these changes
Oct 4, 2022
datho7561
added
the
formatting
don't apologize, you were right to be lenient and now we have a simple method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests on Windows OS
Signed-off-by: azerr azerr@redhat.com