Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNG validator #1425

Merged
merged 1 commit into from
Dec 20, 2022
Merged

RNG validator #1425

merged 1 commit into from
Dec 20, 2022

Conversation

angelozerr
Copy link
Contributor

RNG validator

Signed-off-by: azerr azerr@redhat.com

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor Author

@JessicaJHee I don't cover all error range, but it is a good start for validate RNG file. My idea is to continue to improce error range on another PRs.

Please review it.

@angelozerr
Copy link
Contributor Author

Here a sample with duplicate define:

image

Copy link
Contributor

@JessicaJHee JessicaJHee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and works well! Thank you!

@angelozerr angelozerr merged commit 23c94c5 into eclipse:main Dec 20, 2022
@angelozerr
Copy link
Contributor Author

Thanks @JessicaJHee for your reveiw!

@angelozerr angelozerr added this to the 0.24.0 milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants