Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in comment formatting with xml.format.maxLineWidth #1433

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

JessicaJHee
Copy link
Contributor

Fixes redhat-developer/vscode-xml#851

Signed-off-by: Jessica He jhe@redhat.com

@datho7561 datho7561 self-requested a review January 4, 2023 14:29
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works pretty well, I just found somewhere that the code could be simplified

Signed-off-by: Jessica He <jhe@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks, Jessica!

@datho7561 datho7561 merged commit 84a5962 into eclipse:main Jan 4, 2023
@JessicaJHee JessicaJHee deleted the vscode-851 branch January 4, 2023 22:12
@rgrunber rgrunber mentioned this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legal comments break into lines after formatting
2 participants