Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore linked editing range when there are no referenced node to update #1453

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

angelozerr
Copy link
Contributor

Ignore linked editing range when there are no referenced node to update

Signed-off-by: azerr azerr@redhat.com

@angelozerr angelozerr marked this pull request as ready for review January 13, 2023 18:00
@angelozerr
Copy link
Contributor Author

Given this XML file:

<docbook>
	<xref linkend="s2" />
	<section id="s1" />
</docbook>

with an expression like this:

{
  "pattern": "**/*.xml",
  "expressions": [
    {
      "from": "xref/@linkend",
      "to": "@id"
    }
  ]
}

If s1 is selected, linked editing range not to be activated.

This PR fixes this issue.

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue you mentioned. Thanks, Angelo!

@datho7561 datho7561 added bug Something isn't working linked editing labels Jan 13, 2023
@datho7561 datho7561 added this to the 0.24.0 milestone Jan 13, 2023
@datho7561 datho7561 merged commit b19068b into eclipse:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linked editing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants