Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry/event support #493

Closed
wants to merge 1 commit into from
Closed

Add telemetry/event support #493

wants to merge 1 commit into from

Conversation

angelozerr
Copy link
Contributor

This PR fix #430

The OSUtils was renamed to Platform which is more generic (eclipse like
name) which contains information about OS, JVM (name, version, memory).

Signed-off-by: azerr azerr@redhat.com

@angelozerr
Copy link
Contributor Author

@fbricon here my vscode trace:

[Trace - 15:05:19] Received notification 'telemetry/event'.
Params: {
    "version": "0.8.0-20190701-1255",
    "os": {
        "name": "Windows 10",
        "version": "10.0",
        "arch": "amd64"
    },
    "jvm": {
        "name": "OpenJDK 64-Bit Server VM",
        "version": "1.8.0_212-3-redhat",
        "memory": {
            "free": 520615944,
            "total": 534773760,
            "max": 1073741824
        }
    }
}

@angelozerr angelozerr force-pushed the telemetry branch 3 times, most recently from b39ac8d to 852df7f Compare July 4, 2019 07:46
@angelozerr
Copy link
Contributor Author

@fbricon I have add telemetry to track explicit action from user, that's to say:

  • rename
  • formatting
  • rangeFormatting

In vscode trace, you should see :

[Trace - 09:44:17] Received notification 'telemetry/event'.
Params: "textDocument/formatting"

if you format a XML file.

Copy link
Contributor

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but please add some unit tests before we merge it.

@angelozerr
Copy link
Contributor Author

Looks OK, but please add some unit tests before we merge it.

It will hard to do that since it depends on OS where JUnit are executed (I think about JVM and OS information).

Or perhaps you wish I write test just with rename, formatting, rangeFormatting, and onInitialized but by avoiding value check of OS, JVM memories?

An another question, I tell me if we should give the capability to send telemetry or not. Here some ideas:

  • add settings to disable telemetry?
  • add client capability 'telemetry' to enable telemetry. For instance I think LSP4E will never used those telemetry events.

@fbricon
Copy link
Contributor

fbricon commented Jul 4, 2019

You can check telemetry data contain the same values as what's in Platform, and then check memory values are > 0.

Yes an xml.telemetry.enabled preference would be useful.

@angelozerr
Copy link
Contributor Author

Looks OK, but please add some unit tests before we merge it.

Done with https://github.com/angelozerr/lsp4xml/pull/493/files#diff-06ace1651d73790f809dd84073bc3a86R45

@angelozerr
Copy link
Contributor Author

You can check telemetry data contain the same values as what's in Platform, and then check memory values are > 0.

Ok test was updated.

Yes an xml.telemetry.enabled preference would be useful.

Done in PR redhat-developer/vscode-xml#165

@angelozerr angelozerr force-pushed the telemetry branch 4 times, most recently from 33f2df3 to 024933d Compare July 10, 2019 12:37
}

/**
* Returns the system property from the given key and null otherwise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or "unknown"

This PR fix #430

The OSUtils was renamed to Platform which is more generic (eclipse like
name) which contains information about OS, JVM (name, version, memory).

Signed-off-by: azerr <azerr@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 11, 2021
Telemetry includes:
 * Whether the Java server or the binary server
 * LemMinX version information (from git)
 * Information on the JVM

Please refer to `USAGE_DATA.md` for a full list of data collected.

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 12, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 12, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 12, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 12, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 22, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 24, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 24, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 25, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 25, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Feb 25, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/lemminx that referenced this pull request Mar 8, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes eclipse#430

Rebase of eclipse#493

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit that referenced this pull request Mar 8, 2021
Please refer to `USAGE_DATA.md` for a full list of data collected.

Add `xml.telemetry.enable` to control if telemetry events are sent.

Closes #430

Rebase of #493

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr
Copy link
Contributor Author

Replaced with #989

@angelozerr angelozerr closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add telemetry/event support
2 participants