Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection of external entities depending on line ending #744

Merged
merged 1 commit into from
May 29, 2020

Conversation

angelozerr
Copy link
Contributor

Fix collection of external entities depending on line ending (second try)

See redhat-developer/vscode-xml#262 (comment)

Signed-off-by: azerr azerr@redhat.com

@angelozerr
Copy link
Contributor Author

angelozerr commented May 29, 2020

This PR fix problem (again) with entity hyperlink.

Create this the base.dtd file like this (with some indentation):

              <!ENTITY external3 "A B"><!ENTITY external5 "A B">
                    <!ENTITY external4 "A B">     	
<!ELEMENT root-element (#PCDATA)>
				 	<!ENTITY external "A B">               
<!ENTITY external2 "EXTERNALLY DECLARED ENTITY">

Create this XML file:

<?xml version="1.0" standalone="no"?>
<!DOCTYPE root-element SYSTEM "base.dtd" [
	<!ENTITY local "LOCALLY DECLARED ENTITY">
]>   
<root-element>
&local;    
&external3;   
&external;   
&external4;
&external5;  
&external2;
&undeclared;
</root-element>

Try to go to the definition of &external5; and other, it should work (In master it doesn't work).

@angelozerr angelozerr marked this pull request as ready for review May 29, 2020 13:24
@angelozerr
Copy link
Contributor Author

Tests are written now.

@angelozerr angelozerr force-pushed the entity-hyperlink-bug branch 2 times, most recently from b19bfa0 to 9c4b34b Compare May 29, 2020 15:11
@fbricon fbricon merged commit 291c6fa into eclipse:master May 29, 2020
@fbricon fbricon added this to the 0.12.0 milestone May 29, 2020
@fbricon fbricon added bug Something isn't working DTD labels May 29, 2020
@xorye xorye changed the title Fix collection of external entities depending on line ending (second try) Fix collection of external entities depending on line ending Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DTD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants