Rename not completing with binary #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes redhat-developer/vscode-xml#424 Signed-off-by: azerr <azerr@redhat.com>
|
Was able to reproduce, and this change fixes the issue. 👍 FWIW, you can reproduce by downloading a JVM containing GraalVM from https://github.com/graalvm/graalvm-ce-builds/releases and placing it locally : |
|
Thanks a lot @rgrunber for your review and your great explanation :) |
|
The win32 binary from the GitHub artifacts fixed it for me. 👍 |
Great! Thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename not completing with binary
Fixes redhat-developer/vscode-xml#424
Signed-off-by: azerr azerr@redhat.com