Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart LS via LanguageServerWrapper #839

Open
ddscharfe opened this issue Oct 5, 2023 · 0 comments
Open

Restart LS via LanguageServerWrapper #839

ddscharfe opened this issue Oct 5, 2023 · 0 comments

Comments

@ddscharfe
Copy link
Contributor

In cdt-lsp we want to restart the language server when a configuration file changes (eclipse-cdt/cdt-lsp#214).

This was already discussed in #726.
Calling LanguageServerWrapper::start and then LanguageServerWrapper::stop is not sufficient, because this will not refresh the open editors instantly.
What we'd like to have is a method LanguageServerWrapper::restart(), which stops and starts the language server and reconnects the documents. LanguageServerWrapper::start() already supports this, but only restarts if the server is inactive.

I will provide a PR if there are no objections to this feature.
This was referenced Oct 6, 2023
Merged
Closed
ddscharfe added a commit to ddscharfe/lsp4e that referenced this issue Oct 6, 2023
@ddscharfe
[eclipse#839] Add restart method
babed8b
@ddscharfe ddscharfe mentioned this issue Oct 6, 2023
Merged
ddscharfe added a commit to ddscharfe/lsp4e that referenced this issue Oct 6, 2023
@ddscharfe
[eclipse#839] Add restart method
865fbc4 
- add new method
- bump version
ddscharfe added a commit to ddscharfe/lsp4e that referenced this issue Oct 6, 2023
@ddscharfe
[eclipse#839] Add restart method
027e20c 
- add new method
- bump version
mickaelistria pushed a commit that referenced this issue Oct 6, 2023
@ddscharfe @mickaelistria
[#839] Add restart method
51e5806 
- add new method
- bump version
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Oct 10, 2023
@ghentschke
Use restart() method from LanguageServerWrapper
10e648b 
Since the LanguageServerWrapper provides a restart method we should use
this method instead of stop(). See
eclipse/lsp4e#839
@ghentschke ghentschke mentioned this issue Oct 10, 2023
Merged
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Oct 10, 2023
@ghentschke
Use restart() method from LanguageServerWrapper
4615c22 
Since the LanguageServerWrapper provides a restart method we should use
this method instead of stop(). See
eclipse/lsp4e#839
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Oct 10, 2023
@ghentschke
Use restart() method from LanguageServerWrapper
396b427 
Since the LanguageServerWrapper provides a restart method we should use
this method instead of stop(). See
eclipse/lsp4e#839
ghentschke added a commit to eclipse-cdt/cdt-lsp that referenced this issue Oct 11, 2023
@ghentschke
Use restart() method from LanguageServerWrapper
3b9393b 
Since the LanguageServerWrapper provides a restart method we should use
this method instead of stop(). See
eclipse/lsp4e#839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddscharfe