Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limited Functionality of LSP Editors in MultiPart Editors #859

Open
ddscharfe opened this issue Oct 20, 2023 · 0 comments
Open

Limited Functionality of LSP Editors in MultiPart Editors #859

ddscharfe opened this issue Oct 20, 2023 · 0 comments

Comments

@ddscharfe
Copy link
Contributor

LSP editors, when embedded in MultiPage editors, are not fully functional. While some operations such as formatting work correctly, other features including call hierarchy, find references, renaming, don`t work at all.
ddscharfe added a commit to ddscharfe/lsp4e that referenced this issue Oct 20, 2023
@ddscharfe
Limited Functionality of LSP Editors in MultiPart Editors eclipse#859
d177a81 
- provide base implementation in LSPDocumentAbstractHandler for handlers
which use ITextEditor for their execution
- refactor existing handlers to use new base implementation
- add UI::asTextEditor for obtaining obtaining ITextEditor from an
IEditorPart
- use UI::asTextEditor instead of casts to ITextEditor
@ddscharfe ddscharfe mentioned this issue Oct 20, 2023
Merged
ddscharfe added a commit to ddscharfe/lsp4e that referenced this issue Oct 23, 2023
@ddscharfe
Limited Functionality of LSP Editors in MultiPart Editors eclipse#859
31facd4 
- adapt property testing to check the active IEditorPart
- provide base implementation in LSPDocumentAbstractHandler for handlers
which use ITextEditor for their execution
- refactor existing handlers to use new base implementation
- replace casts to ITextEditor with UI::asTextEditor
ddscharfe added a commit to ddscharfe/lsp4e that referenced this issue Oct 23, 2023
@ddscharfe
Limited Functionality of LSP Editors in MultiPart Editors eclipse#859
60f70f6 
- adapt property testing to check the active IEditorPart
- provide base implementation in LSPDocumentAbstractHandler for handlers
which use ITextEditor for their execution
- refactor existing handlers to use new base implementation
- replace casts to ITextEditor with UI::asTextEditor
- bump version to 0.18.1
mickaelistria pushed a commit that referenced this issue Oct 23, 2023
@ddscharfe @mickaelistria
Limited Functionality of LSP Editors in MultiPart Editors #859
a9d1be3 
- adapt property testing to check the active IEditorPart
- provide base implementation in LSPDocumentAbstractHandler for handlers
which use ITextEditor for their execution
- refactor existing handlers to use new base implementation
- replace casts to ITextEditor with UI::asTextEditor
- bump version to 0.18.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddscharfe