Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folding reconciler is not invoked when document changes #925

Closed
ghentschke opened this issue Feb 23, 2024 · 0 comments · Fixed by #926
Closed

Folding reconciler is not invoked when document changes #925

ghentschke opened this issue Feb 23, 2024 · 0 comments · Fixed by #926

Comments

@ghentschke
Copy link
Contributor

When editing code in a LS backed generic text editor, the folding reconciler is not working as expected. As a user I would expect that the folding reconciler would be invoked while editing the code.

Example: adding new if clause, no folding annotation has been added:
image

I looked into the LSPFoldingReconcilingStrategy and wondered why the reconcile method does nothing:

When calling the reconcile(IRegion subRegion) in:

	@Override
	public void reconcile(DirtyRegion dirtyRegion, IRegion partition) {
		reconcile(dirtyRegion);
	}

...then it works:
image

ghentschke added a commit to ghentschke/lsp4e-bachmann-fixes that referenced this issue Feb 23, 2024
ghentschke added a commit that referenced this issue Feb 26, 2024
- fix possible NPE on concurrent field access

fixes #925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant