Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Declaration (Ctrl + Click / F3) does not collect declarations #969

Closed
travkin79 opened this issue Apr 17, 2024 · 0 comments
Closed

Comments

@travkin79
Copy link
Contributor

I checked an issue in a CDT LSP editor concerning the "open declaration" feature. In a C++ code example, I was able to jumpt to a method's definition, but not to its declaration.

I checked the LSP4E implementation in org.eclipse.lsp4e.operations.declaration.OpenDeclarationHyperlinkDetector and it turns out, the LSP endpoint textDocument/declaration is not used at all (see source code excerpt). I think, in addition to the definitions (and type definitions and implementations), the declarations should be collected here, too.

image

Are there any objections?

travkin79 added a commit to travkin79/lsp4e that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant