Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit test is added for for IllegalStateException: Duplicate RPC meth… #134

Conversation

vrubezhny
Copy link
Contributor

…od runInTerminal issue

Signed-off-by: Victor Rubezhny vrubezhny@redhat.com

Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is too internal and doesn't really test LSP4E debug is functioning, but is instead and internal test which still has some value. I wold simply rename testInitializedDSPDebugTarget to something that clarifies it's more internal stuff, eg testSupportedJSONRPCMethods

…od runInTerminal issue

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny vrubezhny force-pushed the fixDuplicateRPCMethod-runInTerminal-test branch from 410764a to f59e857 Compare May 30, 2022 10:42
@vrubezhny
Copy link
Contributor Author

I think this test is too internal and doesn't really test LSP4E debug is functioning, but is instead and internal test which still has some value. I wold simply rename testInitializedDSPDebugTarget to something that clarifies it's more internal stuff, eg testSupportedJSONRPCMethods

Yes, the intention was to test IDebugProtocolClient implementation (DSPDebugTarget), not the launch itself.
Agreed on renaming the test. Copyright header is added.

@mickaelistria mickaelistria merged commit 2c3228b into eclipse:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants