Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create file on hyperlink #286

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Nov 9, 2022

This PR provides the capability to create a file when hyperlink is processed. vscode provides this feature and it is very good for some usecass. Here a demo which shows the benefit of this PR:

CreateFileOnHyperlink

@mickaelistria
Copy link
Contributor

Good addition! Do you think you can add a test case that covers it?

@rubenporras
Copy link
Contributor

this is indeed a nice feature. Without going into the details, my company has setup very specific dialogs for creating files in the workspace, and the usual create file dialog is not usable.
Do you know if this PR will always open the default create file dialog or if it is configurable? If it is always the default, could we make the new feature optional?

@angelozerr
Copy link
Contributor Author

Good addition!

Glad it please you:)

Do you think you can add a test case that covers it?

I fear that it can be hard to write test since there is a message dialog which is displayed. I never written this kind of test.

Do you know if this PR will always open the default create file dialog or if it is configurable?

If you see the demo, you will notice that there are not some create file dialog, just a confirm dialog which ask to the user if he want to create the file.

@mickaelistria
Copy link
Contributor

I fear that it can be hard to write test since there is a message dialog which is displayed.

OK. Let's merge as it and cross fingers it doesn't regress later. If it does, then it will be a more motivating opportunity to write a test.

@mickaelistria mickaelistria merged commit 387b4ab into eclipse:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants