New API: Port code lenses #433
Conversation
| import org.eclipse.swt.events.MouseEvent; | ||
|
|
||
| public class LSPCodeMining extends LineHeaderCodeMining { | ||
| private CodeLens codeLens; | ||
| private final LanguageServer languageServer; | ||
|
|
||
| // TODO: Store a SingleServerDocumentExecutor instead when that codestream is merged |
There was a problem hiding this comment.
can we just create a small PR with the SingleServerDocumentExecutor, merge it, and the use it here?
I would be quick on the review/merge process, so no need to have here a TODO with a follow up ;)
There was a problem hiding this comment.
Done in #434
There was a problem hiding this comment.
Let me know when you have merged then I will rebase this.
| Boolean resolveProvider = capabilities.getCodeLensProvider().getResolveProvider(); | ||
| return resolveProvider != null && resolveProvider; | ||
| })) { | ||
| if (Boolean.TRUE != this.languageServerWrapper.getServerCapabilities().getCodeLensProvider().getResolveProvider()) { |
There was a problem hiding this comment.
I think
Boolean resolveProvider = capabilities.getCodeLensProvider().getResolveProvider();
if (resolveProvider != null && resolveProvider) {
return CompletableFuture.completedFuture(null);
}
would read better.
There was a problem hiding this comment.
That inverts the logic! I have rewritten it along the lines you suggest, though ;-)
There was a problem hiding this comment.
@ahmedneilhussain , the discussion was not as easy as expected, sorry. If you want you can rebase and fix the comments, then we can merge this one.
ahmedneilhussain
force-pushed
the
new-api/port-code-lenses
branch
from
604da23
to
d3bcf05
Compare
Done I hope |
| .thenApply(codeLenses -> LanguageServers.streamSafely(codeLenses) | ||
| .map(codeLens -> toCodeMining(document, w, codeLens)) | ||
| .filter(Objects::nonNull))) | ||
| .thenApply(result -> result.stream().flatMap(s -> s).collect(Collectors.toList())); |
There was a problem hiding this comment.
Here we could just use toList()
Would you mind taking it as is? I approve of the more succinct form but it's only been added in 'recent' Java. As we still have to support a java 8 customer I'm going to have to backport everything using later constructs when I pull all the new API stuff from public-lsp4e into Cocotec's private fork. It can't be helped, but it does feel a bit like Cruel and Unusual Punishment to be submitting contributions to an open source repository that I will then need to backport in order to take advantage ;-) ;-) |
Ports code lenses across to the new API. Hopefully a straightforward change.