re-add DSPLaunchDelegate.createDebugTarget(...) as deprecated method #654
Conversation
| * return target; | ||
| */ | ||
| final var supplier = streamsSupplier.get(); | ||
| return createDebugTarget(subMonitor, supplier::close, supplier.in, supplier.out, launch, dspParameters); |
There was a problem hiding this comment.
The newer/recommended method should not reference the deprecated one, it would better be the other way round.
There was a problem hiding this comment.
That does not work since the new createDebugTarget method is invoked by public void launch(DSPLaunchDelegateLaunchBuilder builderSrc) of the same class. I would then have to revert all your changes to this class.
If I make the deprecated method delegate to the new method it will effectively never be called, thus overriding it will be without any effect.
|
The code is not functionally equivalent, while with the current master eclipse-wildwebdeveloper/wildwebdeveloper#1174 does work decently (I can debug with vscode-js-debug), this patch leads to a failure on server-side. I suspect one issue is that the Debug target is then not using the correct streams (ie it's trying to keep using the same main stream while a new socket connection to the given port must be made). |
|
I am out of ideas how to solve this in a backwards compatible way then. |
|
Unfortunately I don't see an easy way either, the only viable one would be that you copy DSPLaunchDelegate in your code... I think overall, the simpler and most profitable path for everyone (including you) is to just drop backward compatibility and set narrow version ranges to avoid runtime errors. Would it help if we set the bundle version to 0.16.0 instead of 0.15.2 (I don't have high hopes it makes things really easier, but if can facilitate things, it's also an easy change for LSP4E) |
|
Right now it makes no difference for us if it will be a 0.16.0 or 0.15.2. In the future, the best would be of course if the project follows semver. But I think it would already help if the project commits to always increment the minor version for bundles that introduce backward incompatible changes and only increments the patch version if binary compatibility is guaranteed. |
The signature of the public API method
DSPLaunchDelegate.createDebugTargetwas changed by 1e52445 resulting in compile / linkage errors in our projects where we need to override it.This PR re-adds the method with the old signature as deprecated to allow graceful API transition phase.