Fix SWT Resource not properly disposed on LSPSymbolInWorkspaceDialog #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
rubenporras
reviewed
Sep 13, 2023
| @@ -56,10 +57,13 @@ public Object execute(ExecutionEvent event) throws ExecutionException { | |||
| if (site == null) { | |||
| return null; | |||
| } | |||
| final var dialog = new LSPSymbolInWorkspaceDialog(site.getShell(), project); | |||
| var styleProvider = new BoldStylerProvider(site.getShell().getFont()); | |||
| final var dialog = new LSPSymbolInWorkspaceDialog(site.getShell(), project, styleProvider); | |||
| if (dialog.open() != IDialogConstants.OK_ID) { | |||
There was a problem hiding this comment.
what about
int code = dialog.open();
styleProvider.dispose();
if (code != IDialogConstants.OK_ID) {
return null;
}
then we do not need to repeat the dispose call in both branches
ghentschke
added a commit
to ghentschke/lsp4e-bachmann-fixes
that referenced
this pull request
Sep 13, 2023
see comment eclipse#801 (comment)
Merged
rubenporras
pushed a commit
that referenced
this pull request
Sep 13, 2023
see comment #801 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #800