Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumps #806

Merged
merged 1 commit into from Sep 14, 2023
Merged

Version bumps #806

merged 1 commit into from Sep 14, 2023

Conversation

ghentschke
Copy link
Contributor

0.17.3 due to new format-on-save feature by PR #783

@mickaelistria
Copy link
Contributor

Do you have any idea why this wasn't detected while building previous PR?

@ghentschke
Copy link
Contributor Author

I have no idea :-/

@mickaelistria
Copy link
Contributor

Actually, master builds fine https://ci.eclipse.org/lsp4e/job/lsp4e-github/job/master/457/ . What makes you think this bump is necessary? I think version was already bumped since last release.

@ghentschke
Copy link
Contributor Author

CDT-LSP implements IFormatRegionsProvider. I want to update the LSP4E bundle-version in our manifest file to ensure that the correct version of LSP4E will be fetched.

@mickaelistria
Copy link
Contributor

OK, bumping the micro segment 1 extra time isn't a too bad thing to do.

0.17.3 due to new format-on-save feature by PR eclipse#783
@mickaelistria mickaelistria merged commit 8fdbfa8 into eclipse:master Sep 14, 2023
2 checks passed
@ghentschke
Copy link
Contributor Author

Thanks!

@ghentschke ghentschke deleted the version-bumb branch September 14, 2023 08:48
@rubenporras
Copy link
Contributor

There is a type on the PR, it is not bumb, but bump.

@ghentschke , Could you change the PR title? I am not sure, but might need to change that in the release notes ;)

@ghentschke ghentschke changed the title Version bumbs Version bumps Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants