Support termination of virtual DSPProcess #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
requested changes
Oct 3, 2023
org.eclipse.lsp4e.debug/src/org/eclipse/lsp4e/debug/console/DSPProcess.java
Outdated
Show resolved
Hide resolved
The DSPProcess not always maps to an actual process, but when it does, we use it to control termination actions and state, and if it doesn't we failback to an internal state. This makes that the "Terminate" button on the Console works.
mickaelistria
force-pushed
the
terminate-button-on-console
branch
from
46a8a23
to
fee8da8
Compare
jonahgraham
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DSPProcess not always maps to an actual process, but when it does, we use it to control termination actions and state, and if it doesn't we failback to an internal state.
This makes that the "Terminate" button on the Console works.