Prevent failure of DocumentContentSynchronizer.<init> #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
force-pushed
the
DocumentContentSynchronizer
branch
from
f7933d7
to
ad58b09
Compare
rubenporras
force-pushed
the
DocumentContentSynchronizer
branch
from
ad58b09
to
3afc551
Compare
|
I wonder if we actually need a warning or if we just can take 0L as default without bothering the user with a warning. What do you think @mickaelistria ? |
|
I don't think I ever encountered this use-case, so I don't have anything relevant to answer here. I think this patch is fine as it, so if you think it's worth merging it now, please do. If you think it's better to not log, then don't log and merge it. I fully trust your judgement here ;) |
does not have an URI registered in EFS and it is not a file uri. Also improve the existing log to include the URI that we are failing to deal with.
rubenporras
force-pushed
the
DocumentContentSynchronizer
branch
from
3afc551
to
5ab838a
Compare
|
Thanks, I think the code can handle the case quite well by taking the default value of |
rubenporras
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent failure of DocumentContentSynchronizer. if the document
does not have an URI registered in EFS and it is not a file uri.
Also improve the existing log to include the URI that we are failing to
deal with.