Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Maven Artifacts from the target #851

Merged
merged 1 commit into from Oct 18, 2023

Conversation

rubenporras
Copy link
Contributor

Remove Maven Artifacts from the target, as the lastest version of PDE cannot resolve them.

Remove Maven Artifacts from the target, as the lastest version of PDE cannot resolve them.
@akurtakov
Copy link
Contributor

PDE needs M2e PDE feature being installed (https://www.eclipse.org/downloads/download.php?file=/technology/m2e/releases/2.4.0/features/org.eclipse.m2e.pde.feature_2.2.200.20230820-0922.jar ) in order to resolve Maven directly. Do you have it installed?

@rubenporras
Copy link
Contributor Author

I did not, but I have installed it, restared, and still the target cannot be loaded. See this screenshot:

image

any suggestions what could be wrong?

@akurtakov
Copy link
Contributor

Would you please try to edit the feature (without changing anything) to force pde to re-resolve it?

@rubenporras
Copy link
Contributor Author

I have increased sequenceNumber, saved and refreshed. Same problem.

@akurtakov
Copy link
Contributor

Hmm, it works for me. Would you please explicitly click Edit on
image

@rubenporras
Copy link
Contributor Author

I tried that already, it did not work either. Creating a new workspace and importing the lsp4e project again, and loading the target file in the new workspace did not work either.
Could you maybe try with the target file of lsp4e that I am modifying in this PR, and not the one from TM4E?

@akurtakov
Copy link
Contributor

I reproduce it with lsp4e. Please give me few hours to investigate before pushing this one. I'll get back here.

@rubenporras
Copy link
Contributor Author

@akurtakov , it is a missing feature (#849 (reply in thread)), I would suggest that we merge this PR then, as it is very inconvenient if people clone our repo and cannot work with it out of the box, and I do not see any drawback of using just p2 locations. Do you agree?

@akurtakov
Copy link
Contributor

@akurtakov , it is a missing feature (#849 (reply in thread)), I would suggest that we merge this PR then, as it is very inconvenient if people clone our repo and cannot work with it out of the box, and I do not see any drawback of using just p2 locations. Do you agree?

OK. Go for it.

@rubenporras rubenporras merged commit 0c1970d into eclipse:master Oct 18, 2023
1 of 2 checks passed
@rubenporras rubenporras deleted the RemoveMavenFromTarget branch October 18, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants