Add rough sketch for a bugfix for #885 #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-brangs
force-pushed
the
issue-885-problem-occurred-popup
branch
from
98be719
to
7f8a855
Compare
|
The test However, I don't know if this fully solves the problem with missing The markers rule seems to be |
erik-brangs
force-pushed
the
issue-885-problem-occurred-popup
branch
from
7f8a855
to
20ab024
Compare
| } | ||
| for (Entry<IMarker, Diagnostic> entry : toUpdate.entrySet()) { | ||
| Map<String, Object> markerAttributes = computeMarkerAttributes(document, entry.getValue(), resource); | ||
| updateMarker(markerAttributes, entry.getKey()); | ||
| if (resource.exists()) { |
There was a problem hiding this comment.
couldn't it be if (entry.getKey().exists()) here instead?
There was a problem hiding this comment.
Yes, you're right.
…ources that do not exist (eclipse#885) Due to job scheduling, the job may run after the resources are no longer accessible (e.g. because the project was closed).
erik-brangs
force-pushed
the
issue-885-problem-occurred-popup
branch
from
20ab024
to
367a2ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @mickaelistria in #885 , here is a pull request that highlights where exists() checks might be missing.
The fix is probably wrong because I wasn't actually able to reproduce the problem. The associated test seems to trigger a different problem.
I suppose the original problem is triggered by the order of operations. I don't know enough to reproduce it in a test case.